Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1539)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1146073003: Image elements can have inline layout objects (Closed)

Created:
5 years, 7 months ago by rhogan
Modified:
5 years, 7 months ago
Reviewers:
pdr., esprehn, inferno
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Image elements can have inline layout objects If it has a content: directive and no source then an image element will get an inline renderer, so we can't assume that an image is always a box. I'd resisted introducing this check as I felt that it wasn't possible but clearly didn't experiment enough. BUG=491582 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195920

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
A LayoutTests/fast/replaced/image-map-on-inline-image.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/replaced/image-map-on-inline-image-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/layout/HitTestResult.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
rhogan
5 years, 7 months ago (2015-05-24 17:36:57 UTC) #2
pdr.
LGTM https://codereview.chromium.org/1146073003/diff/1/LayoutTests/fast/replaced/image-map-on-inline-image.html File LayoutTests/fast/replaced/image-map-on-inline-image.html (right): https://codereview.chromium.org/1146073003/diff/1/LayoutTests/fast/replaced/image-map-on-inline-image.html#newcode1 LayoutTests/fast/replaced/image-map-on-inline-image.html:1: <style> Can you add a <!DOCTYPE HTML> here ...
5 years, 7 months ago (2015-05-25 21:41:42 UTC) #3
esprehn
We just shouldn't even go down the content path, the hasContent() should really probably check ...
5 years, 7 months ago (2015-05-26 00:33:08 UTC) #5
rhogan
On 2015/05/26 at 00:33:08, esprehn wrote: > We just shouldn't even go down the content ...
5 years, 7 months ago (2015-05-26 18:06:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146073003/20001
5 years, 7 months ago (2015-05-26 18:07:25 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 19:42:14 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195920

Powered by Google App Engine
This is Rietveld 408576698