Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1146063005: BackgroundSync sync events need to be ExtendableEvents, content side cleanup (Closed)

Created:
5 years, 6 months ago by chasej
Modified:
5 years, 6 months ago
Reviewers:
michaeln, jkarlin
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tzik, serviceworker-reviews, jam, jsbell+serviceworker_chromium.org, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@486890-syncevent-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BackgroundSync sync events need to be ExtendableEvents, cleanup This is part of a series of patches to correctly fire the Sync event as an ExtendableEvent, instead of a regular Event [1/4] https://codereview.chromium.org/1162243003/, content side fix [2/4] https://codereview.chromium.org/1148293011/, blink side fix [3/4] https://codereview.chromium.org/1160253004/, content browser tests [4/4] This patch, cleanup on content side Specific changes in this patch: - Remove obsolete function from content worker context client - Overloaded function made obsolete by landing blink and content patches BUG=486890 Committed: https://crrev.com/124f100e5173e39d671b759d8d897e55bf209ba1 Cr-Commit-Position: refs/heads/master@{#334946}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M content/renderer/service_worker/service_worker_context_client.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jkarlin
lgtm!
5 years, 6 months ago (2015-06-17 17:00:41 UTC) #2
chasej
michaeln, please take a look.
5 years, 6 months ago (2015-06-17 21:05:39 UTC) #4
michaeln
lgtm 2 (hooray deletes)
5 years, 6 months ago (2015-06-17 22:28:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146063005/20001
5 years, 6 months ago (2015-06-17 22:43:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-17 22:49:11 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 22:51:13 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/124f100e5173e39d671b759d8d897e55bf209ba1
Cr-Commit-Position: refs/heads/master@{#334946}

Powered by Google App Engine
This is Rietveld 408576698