Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6368)

Unified Diff: cc/layers/viewport.cc

Issue 1146053009: Added experiment for changing viewport scroll ordering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: aelias review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/viewport.cc
diff --git a/cc/layers/viewport.cc b/cc/layers/viewport.cc
index 944f1bbd3cfc45012f17cfcca4173faf164cb3ae..35db561e28a2ec442417fa85f0508c3726a54bac 100644
--- a/cc/layers/viewport.cc
+++ b/cc/layers/viewport.cc
@@ -24,13 +24,23 @@ Viewport::Viewport(LayerTreeHostImpl* host_impl)
DCHECK(host_impl_);
}
+void Viewport::Pan(const gfx::Vector2dF& delta) {
+ gfx::Vector2dF pending_delta = delta;
+
+ pending_delta -= host_impl_->ScrollLayer(InnerScrollLayer(),
+ pending_delta,
+ gfx::Point(),
+ false);
+}
+
Viewport::ScrollResult Viewport::ScrollBy(const gfx::Vector2dF& delta,
const gfx::Point& viewport_point,
- bool is_wheel_scroll) {
+ bool is_wheel_scroll,
+ bool affect_top_controls) {
gfx::Vector2dF content_delta = delta;
ScrollResult result;
- if (ShouldTopControlsConsumeScroll(delta)) {
+ if (affect_top_controls && ShouldTopControlsConsumeScroll(delta)) {
result.top_controls_applied_delta = ScrollTopControls(delta);
content_delta -= result.top_controls_applied_delta;
}

Powered by Google App Engine
This is Rietveld 408576698