Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 1146053009: Added experiment for changing viewport scroll ordering. (Closed)

Created:
5 years, 6 months ago by bokan
Modified:
5 years, 6 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added experiment for changing viewport scroll ordering. This is the first in a series of patches to experiment with modifying how the Blink viewport scrolls. This patch adds a command-line flag, about:flags experiment and Chromium-side setting for the experiment and implements the first change related to the experiment: limiting scrolling on a pinch-zoom gesture to the visual (inner) viewport only. BUG=443724 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/9e55696155786e6e64045d594c5fc3720e979fd5 Cr-Commit-Position: refs/heads/master@{#333540}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : aelias review #

Total comments: 2

Patch Set 5 : Fixed comment #

Patch Set 6 : Added new about_flag to histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -22 lines) Patch
M cc/layers/viewport.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M cc/layers/viewport.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 3 chunks +24 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 2 chunks +7 lines, -4 lines 0 comments Download
M content/public/common/web_preferences.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (10 generated)
bokan
Hi Alexandre, ptal.
5 years, 6 months ago (2015-06-05 18:30:03 UTC) #1
bokan
+aelias@
5 years, 6 months ago (2015-06-08 15:47:21 UTC) #3
aelias_OOO_until_Jul13
lgtm modulo nits https://codereview.chromium.org/1146053009/diff/40001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1146053009/diff/40001/chrome/app/generated_resources.grd#newcode6769 chrome/app/generated_resources.grd:6769: + Enables fliped viewport scroll order ...
5 years, 6 months ago (2015-06-09 04:02:44 UTC) #4
bokan
https://codereview.chromium.org/1146053009/diff/40001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1146053009/diff/40001/chrome/app/generated_resources.grd#newcode6769 chrome/app/generated_resources.grd:6769: + Enables fliped viewport scroll order in some situations. ...
5 years, 6 months ago (2015-06-09 11:49:04 UTC) #5
bokan
+kenrb@ for common_param_traits_macros +avi@ for content/public and content/renderer
5 years, 6 months ago (2015-06-09 11:51:57 UTC) #7
kenrb
ipc lgtm
5 years, 6 months ago (2015-06-09 13:55:55 UTC) #8
Avi (use Gerrit)
LGTM with comment fix. https://codereview.chromium.org/1146053009/diff/60001/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/1146053009/diff/60001/content/public/common/content_switches.cc#newcode610 content/public/common/content_switches.cc:610: // and portrait mode (i.e. ...
5 years, 6 months ago (2015-06-09 14:40:26 UTC) #9
bokan
https://codereview.chromium.org/1146053009/diff/60001/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/1146053009/diff/60001/content/public/common/content_switches.cc#newcode610 content/public/common/content_switches.cc:610: // and portrait mode (i.e. Android) so the page ...
5 years, 6 months ago (2015-06-09 15:09:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146053009/80001
5 years, 6 months ago (2015-06-09 15:10:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/26145)
5 years, 6 months ago (2015-06-09 16:22:47 UTC) #15
bokan
+asvitkine@ for histograms.xml
5 years, 6 months ago (2015-06-09 16:50:06 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146053009/100001
5 years, 6 months ago (2015-06-09 16:51:16 UTC) #20
Alexei Svitkine (slow)
lgtm
5 years, 6 months ago (2015-06-09 17:08:41 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-09 17:57:00 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146053009/100001
5 years, 6 months ago (2015-06-09 18:37:22 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 6 months ago (2015-06-09 18:41:37 UTC) #26
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 18:42:27 UTC) #27
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/9e55696155786e6e64045d594c5fc3720e979fd5
Cr-Commit-Position: refs/heads/master@{#333540}

Powered by Google App Engine
This is Rietveld 408576698