posix LaunchProcess: Don't use STL iterators after fork.

posix LaunchProcess: Don't use STL iterators after fork.

Fixes some deadlocks on linux debug caused by STL debug iterators using locks.

BUG=331459
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243401

[willchan no longer on Chromium, 2014-01-07 00:55:50]

This is the right overall thing to do, but I don't have time to do a detailed
review. Pawel, can you review this? If not, I recommend asking an STL expert
like jyasskin. He might also tell you to rewrite this in good ol C instead :P
Which is a nice to do if you had the time, but not required.

[Paweł Hajdan Jr., 2014-01-07 10:51:09]

LGTM, thanks!

[willchan no longer on Chromium, 2014-01-07 15:43:01]

LGTM rubberstamp then, thanks!

On Tue, Jan 7, 2014 at 2:51 AM,  <phajdan.jr@chromium.org> wrote:
> LGTM, thanks!
>
> https://codereview.chromium.org/114603009/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-07 18:37:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/114603009/1

[commit-bot: I haz the power, 2014-01-07 22:06:02]

Change committed as 243401

[Elliot Glaysher, 2014-01-07 22:33:13]

https://codereview.chromium.org/114603009/diff/1/base/process/launch_posix.cc
File base/process/launch_posix.cc (right):

https://codereview.chromium.org/114603009/diff/1/base/process/launch_posix.cc...
base/process/launch_posix.cc:550: std::copy(fd_shuffle1.begin(),
fd_shuffle1.end(),
So maybe I'm wrong here, but isn't this using stl iterators in a block that says
above that it can't use STL iterators?

[mattm, 2014-01-07 22:43:40]

https://codereview.chromium.org/114603009/diff/1/base/process/launch_posix.cc
File base/process/launch_posix.cc (right):

https://codereview.chromium.org/114603009/diff/1/base/process/launch_posix.cc...
base/process/launch_posix.cc:550: std::copy(fd_shuffle1.begin(),
fd_shuffle1.end(),
On 2014/01/07 22:33:14, Elliot Glaysher wrote:
> So maybe I'm wrong here, but isn't this using stl iterators in a block that
says
> above that it can't use STL iterators?

Oh, yeah. I missed this one and I must not have been using a test that hits
this. Good catch, I'll make a followup cl, thanks!