Issue 1146013005: Only update icon if the new one is not null on x11, no-op for null icon (follow the same way as Win…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1146013005: Only update icon if the new one is not null on x11, no-op for null icon (follow the same way as Win… (Closed)

Created:
5 years, 7 months ago by laforge

Modified:
5 years, 7 months ago

Reviewers:

CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2357

Target Ref:
refs/pending/branch-heads/2357

Project:
chromium

Visibility:
Public.

Only update icon if the new one is not null on x11, no-op for null icon (follow the same way as Windows platform does in HWNDMessageHandler::SetWindowIcons) BUG=478714 . Review URL: https://codereview.chromium.org/1138343003 Cr-Commit-Position: refs/heads/master@{#329704} (cherry picked from commit eb6d82cd81c4e0a4dc528e98630283b17e17e2d9) Committed: https://chromium.googlesource.com/chromium/src/+/41ca3ae2038deb2c132c3390c324011707fef969

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 1 (0 generated)

laforge

5 years, 7 months ago (2015-05-22 04:47:05 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
41ca3ae2038deb2c132c3390c324011707fef969.