Source/core/layout/LayoutBoxModelObject.h - Issue 1145993002: Refactor root element background painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBoxModelObject.h

Issue 1145993002: Refactor root element background painting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix under invalidation (override LayoutView::visualOverflowRect), revise LayoutBoxModelObject::styl… Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutBoxModelObject.h

diff --git a/Source/core/layout/LayoutBoxModelObject.h b/Source/core/layout/LayoutBoxModelObject.h

index 1b8983ad4bf164df154962e63a163809af3f32b3..52b5f5b4900b9f875d6adfefa2612d45f55d19ac 100644

--- a/Source/core/layout/LayoutBoxModelObject.h

+++ b/Source/core/layout/LayoutBoxModelObject.h

@@ -204,6 +204,11 @@ public:

void invalidateDisplayItemClientOnBacking(const DisplayItemClientWrapper&) const;

+ // http://www.w3.org/TR/css3-background/#body-background

+ // <html> root element with no background steals background from its first <body> child.

+ // The used background for such body element should be the initial value. (i.e. transparent)

+ bool backgroundStolenForBeingBody(const ComputedStyle* rootElementStyle = nullptr) const;

protected:

virtual void willBeDestroyed() override;