Source/core/layout/LayoutObject.cpp - Issue 1145993002: Refactor root element background painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutObject.cpp

Issue 1145993002: Refactor root element background painting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: revert to patchset 10 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutObject.cpp

diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp

index 7dfacf819fc7be405711d7b918c87b89a3336161..c4192276a15c74ab18260f6504700cf9d17802f5 100644

--- a/Source/core/layout/LayoutObject.cpp

+++ b/Source/core/layout/LayoutObject.cpp

@@ -2300,23 +2300,6 @@ bool LayoutObject::isRooted() const

return false;

}

-LayoutObject* LayoutObject::layoutObjectForRootBackground()

- ASSERT(isDocumentElement());

- if (!hasBackground() && isHTMLHtmlElement(node())) {

- // Locate the <body> element using the DOM. This is easier than trying

- // to crawl around a layout tree with potential :before/:after content and

- // anonymous blocks created by inline <body> tags etc. We can locate the <body>

- // layout object very easily via the DOM.

- HTMLElement* body = document().body();

- LayoutObject* bodyObject = isHTMLBodyElement(body) ? body->layoutObject() : 0;

- if (bodyObject)

- return bodyObject;

- }

- return this;

RespectImageOrientationEnum LayoutObject::shouldRespectImageOrientation() const

{

// Respect the image's orientation if it's being used as a full-page image or it's

@@ -3169,15 +3152,6 @@ void LayoutObject::setShouldDoFullPaintInvalidation(PaintInvalidationReason reas

if (reason == PaintInvalidationFull)

reason = documentLifecycleBasedPaintInvalidationReason(document().lifecycle());

m_bitfields.setFullPaintInvalidationReason(reason);

- if (RuntimeEnabledFeatures::slimmingPaintEnabled() && isBody()) {

- // The rootObject paints view's background. We need to invalidate it when

- // view's background changes because of change of body's style.

- // FIXME: The condition is broader than needed for simplicity.

- // Might remove this when fixing crbug.com/475115.

- if (LayoutObject* rootObject = document().documentElement()->layoutObject())

- rootObject->setShouldDoFullPaintInvalidation();

- }

}

if (!isUpgradingDelayedFullToFull) {

« Source/core/layout/LayoutBoxModelObject.cpp ('K') | « Source/core/layout/LayoutObject.h ('k') | Source/core/layout/LayoutView.h » ('j') | Source/core/paint/BoxPainter.cpp » ('J')