Refactor root element background painting

Source/core/style/FillLayer.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 350 matching lines @@
     }
 
     return true;
 }
 
 bool FillLayer::hasOpaqueImage(const LayoutObject* layoutObject) const
 {
     if (!m_image)
         return false;
 
-    if (m_composite == CompositeClear || m_composite == CompositeCopy)
+    if (m_composite == CompositeClear)
         return true;
 
     if (m_blendMode != WebBlendModeNormal)
         return false;
 
+    if (m_composite == CompositeCopy)

[chrishtr, 2015/06/09 21:07:54]

Why this change?

[trchen, 2015/06/09 23:36:08]

Not necessary in this CL. Just fix it on the way when I saw it.

Blending is applied before compositing. Non-default blending with composite:copy
means first absorbing color from below, then discard the layer below, thus not
really being opaque.

[chrishtr, 2015/06/10 01:03:39]

Ok please move into another patch then.

[trchen, 2015/06/10 01:41:05]

Done.

+        return true;
+
     if (m_composite == CompositeSourceOver)
         return m_image->knownToBeOpaque(layoutObject);
 
     return false;
 }
 
 bool FillLayer::hasRepeatXY() const
 {
     return m_repeatX == RepeatFill && m_repeatY == RepeatFill;
 }
 
 } // namespace blink