LayoutTests/fast/transforms/transformed-document-element.html - Issue 1145993002: Refactor root element background painting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/transforms/transformed-document-element.html

Issue 1145993002: Refactor root element background painting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/backgrounds/bgCompositeCopy.html ('K') | « LayoutTests/fast/repaint/view-background-from-body-1.html ('k') | LayoutTests/platform/android/fast/backgrounds/bgCompositeCopy-expected.png » ('j') | LayoutTests/platform/android/svg/transforms/animated-path-inside-transformed-html-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"	1 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"

2 "http://www.w3.org/TR/html4/loose.dtd">	2 "http://www.w3.org/TR/html4/loose.dtd">

3	3

4 <html lang="en">	4 <html lang="en">

5 <head>	5 <head>

6 <meta http-equiv="Content-Type" content="text/html; charset=utf-8">	6 <meta http-equiv="Content-Type" content="text/html; charset=utf-8">

7 <title>Transform on Document</title>	7 <title>Transform on Document</title>

8 </head>	8 </head>

9 <body style="background-color: gray">	9 <body style="background-image:url('../../compositing/repaint/resources/grid.png' )">
	chrishtr 2015/06/09 21:07:52 Are you trying to test a new scenario? Why delete Are you trying to test a new scenario? Why delete the old test, is it a duplicate of another test? trchen 2015/06/09 23:36:07 The old test is incorrect. The background color of Show quoted text On 2015/06/09 21:07:52, chrishtr wrote: > Are you trying to test a new scenario? Why delete the old test, is it a > duplicate of another test? The old test is incorrect. The background color of the root element should expand to cover the viewport even with rotation, not painting a diamond shape. Using a gray solid color doesn't verify the background is positioned correctly, thus changed to use an image.
10 <p>The portions of the view exposed by the transformed document should be painte d white</p>	10 <p>The background of root element shall respect transform but expands to the who le viewport.</p>

11 <script type="text/javascript" charset="utf-8">	11 <script type="text/javascript" charset="utf-8">

12 // do this dynamically to avoid pixels from the previous test in potentially u npainted areas	12 // do this dynamically to avoid pixels from the previous test in potentially u npainted areas

13 document.documentElement.style.webkitTransform = 'translateY(200px) rotate(20d eg)';	13 document.documentElement.style.webkitTransform = 'translateY(200px) rotate(20d eg)';

14 </script>	14 </script>

15 </body>	15 </body>

16 </html>	16 </html>

OLD	NEW