LayoutTests/fast/backgrounds/bgCompositeCopy.html - Issue 1145993002: Refactor root element background painting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/backgrounds/bgCompositeCopy.html

Issue 1145993002: Refactor root element background painting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/TestExpectations ('K') | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/backgrounds/bgCompositeCopy-expected.png » ('j') | LayoutTests/fast/transforms/transformed-document-element.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <head>

2 <style>

3 div {

4 background-image:url(resources/rgba16.png);
chrishtr 2015/06/09 21:07:52 Why delete this test? Why delete this test? trchen 2015/06/09 23:36:07 This test was designed incorrectly, and the implem Show quoted text On 2015/06/09 21:07:52, chrishtr wrote: > Why delete this test? This test was designed incorrectly, and the implementation was wrong too. CSS requires that background layers always create an isolation group (i.e. context.saveLayer() then merge the layer down using src-over), thus applying -webkit-background-composite:copy on the bottom layer is no different from the default (src-over) because the isolation group starts with transparent pixels. Actually I want to propose to remove -webkit-background-composite. It is not documented in any w3c draft, nor any webkit blog posts. The document at developer.apple.com is bogus. I don't think anyone cares. chrishtr 2015/06/10 01:03:39 Ok please file a but to track removal then. Sounds Show quoted text On 2015/06/09 at 23:36:07, trchen wrote: > On 2015/06/09 21:07:52, chrishtr wrote: > > Why delete this test? > > This test was designed incorrectly, and the implementation was wrong too. > > CSS requires that background layers always create an isolation group (i.e. context.saveLayer() then merge the layer down using src-over), thus applying -webkit-background-composite:copy on the bottom layer is no different from the default (src-over) because the isolation group starts with transparent pixels. > > Actually I want to propose to remove -webkit-background-composite. It is not documented in any w3c draft, nor any webkit blog posts. The document at developer.apple.com is bogus. I don't think anyone cares. Ok please file a but to track removal then. Sounds good to remove. trchen 2015/06/10 01:41:05 crbug.com/498588 crbug.com/498588
5 -webkit-background-composite:copy;

6 }

7 </style>

8 </head>

9

10 <body>

11

12 <div style="width:85px; height:62px"></div>

13

14 </body>

OLD	NEW