Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1145973009: Add a simple inksplash example (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a simple inksplash example We'll eventually turn this into a full fn2 component, but for now it's just an example. To make this work, I created a schedule.dart as a start to implementing scheduler.md. For now, I've kept the API similar to the web platform so that the old world can continue use it backed by sky.window.requestAnimationFrame. R=eseidel@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/0cb5198b731fc2b4710d327d5899f92cdc4dca02

Patch Set 1 #

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -9 lines) Patch
A sky/examples/raw/ink_well.dart View 1 1 chunk +70 lines, -0 lines 0 comments Download
M sky/examples/raw/touch_demo.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sky/sdk/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/framework/animation/generators.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/app.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/rendering/render_node.dart View 2 chunks +2 lines, -4 lines 0 comments Download
A sky/sdk/lib/framework/scheduler.dart View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-05-29 20:51:43 UTC) #1
eseidel
lgtm Love the new scheduler. You had me create an fn2 examples dir, you might ...
5 years, 6 months ago (2015-05-29 20:53:11 UTC) #2
abarth-chromium
On 2015/05/29 at 20:53:11, eseidel wrote: > Love the new scheduler. You had me create ...
5 years, 6 months ago (2015-05-29 20:54:54 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-05-29 20:55:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0cb5198b731fc2b4710d327d5899f92cdc4dca02 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698