Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: public/web/WebFrameClient.h

Issue 1145973006: Add enum that specifies the frame detachment reason. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: moving enum Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | public/web/WebRemoteFrameClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 // frame and returns a new WebFrame. The WebFrame is considered in-use 148 // frame and returns a new WebFrame. The WebFrame is considered in-use
149 // until frameDetached() is called on it. 149 // until frameDetached() is called on it.
150 // Note: If you override this, you should almost certainly be overriding 150 // Note: If you override this, you should almost certainly be overriding
151 // frameDetached(). 151 // frameDetached().
152 virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, WebSandboxFlags sandboxFlags) { return nullptr; } 152 virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, WebSandboxFlags sandboxFlags) { return nullptr; }
153 153
154 // This frame set its opener to null, disowning it. 154 // This frame set its opener to null, disowning it.
155 // See http://html.spec.whatwg.org/#dom-opener. 155 // See http://html.spec.whatwg.org/#dom-opener.
156 virtual void didDisownOpener(WebLocalFrame*) { } 156 virtual void didDisownOpener(WebLocalFrame*) { }
157 157
158 // Specifies the reason for the detachment.
159 enum WebDetachReason { Remove, Swap };
dcheng 2015/06/01 20:06:46 enum class instead of enum. Also, let's call this
lfg 2015/06/01 20:22:15 Done.
160
158 // This frame has been detached from the view, but has not been closed yet. 161 // This frame has been detached from the view, but has not been closed yet.
159 virtual void frameDetached(WebFrame*) { } 162 virtual void frameDetached(WebFrame*) { }
160 163
161 // This frame has become focused.. 164 // This frame has become focused..
162 virtual void frameFocused() { } 165 virtual void frameFocused() { }
163 166
164 // This frame is about to be closed. This is called after frameDetached, 167 // This frame is about to be closed. This is called after frameDetached,
165 // when the document is being unloaded, due to new one committing. 168 // when the document is being unloaded, due to new one committing.
166 virtual void willClose(WebFrame*) { } 169 virtual void willClose(WebFrame*) { }
167 170
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
643 // App Banners --------------------------------------------------------- 646 // App Banners ---------------------------------------------------------
644 virtual WebAppBannerClient* appBannerClient() { return 0; } 647 virtual WebAppBannerClient* appBannerClient() { return 0; }
645 648
646 protected: 649 protected:
647 virtual ~WebFrameClient() { } 650 virtual ~WebFrameClient() { }
648 }; 651 };
649 652
650 } // namespace blink 653 } // namespace blink
651 654
652 #endif 655 #endif
OLDNEW
« no previous file with comments | « no previous file | public/web/WebRemoteFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698