Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 1145963003: Revert Disable Rotation on Login Pages (Closed)

Created:
5 years, 7 months ago by jonross
Modified:
5 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert Disable Rotation on Login Pages Revert "This change is intended to M-43. Currently screen rotation animations expose a bug, causing the login screen to not be useable. Disable rotation animations while a user is not logged in. This will be later reverted on M-44 where a fix to the underlying issue will be landed." This reverts commit 274e83a41a63c1746203bc1cee8cefd07ae821c9. Original review: https://codereview.chromium.org/1139793003/ The underlying bug was fixed via: https://codereview.chromium.org/1125283015/ TBR=oshima@chromium.org BUG=chrome-os-partner:40118 Committed: https://crrev.com/d30c42fcebbeee085a6fbdfef9c98cf02d02c3bd Cr-Commit-Position: refs/heads/master@{#330737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M ash/rotator/screen_rotation_animator.cc View 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145963003/1
5 years, 7 months ago (2015-05-20 14:48:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 15:27:20 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 15:29:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d30c42fcebbeee085a6fbdfef9c98cf02d02c3bd
Cr-Commit-Position: refs/heads/master@{#330737}

Powered by Google App Engine
This is Rietveld 408576698