Issue 1145953003: [Effen] Move responsibility for inserting nodes to the OneChildListRenderNodeWrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1145953003: [Effen] Move responsibility for inserting nodes to the OneChildListRenderNodeWrapper. (Closed)

Created:
5 years, 7 months ago by Hixie

Modified:
5 years, 7 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

[Effen] Move responsibility for inserting nodes to the OneChildListRenderNodeWrapper. Before, OneChildListRenderNodeWrappers were responsible for removing the child nodes' RenderCSS nodes from their containers, and for moving those around when nodes were reordered. Now, they're also responsible for adding them. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5418b3e0782abd2f724b637b0dfbb359633e0fa6

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -18 lines)			Patch
	M	sky/sdk/lib/framework/fn.dart	View		18 chunks	+47 lines, -18 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 7 months ago (2015-05-20 22:56:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5418b3e0782abd2f724b637b0dfbb359633e0fa6 (presubmit successful).