Chromium Code Reviews Chromium Code Reviews
Issue 11459003:
Add Start/Stop event signalling on Prerenders. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/test/data/prerender/prerender_loader_removing_links.html |
| diff --git a/chrome/test/data/prerender/prerender_loader_removing_links.html b/chrome/test/data/prerender/prerender_loader_removing_links.html |
| index 08d4037f228088f3be6686ffe8823dfc42892605..512befb61cfcb536ed6579c3ba197cabff0fbd6e 100644 |
| --- a/chrome/test/data/prerender/prerender_loader_removing_links.html |
| +++ b/chrome/test/data/prerender/prerender_loader_removing_links.html |
| @@ -11,27 +11,40 @@ function ExtractGetParameterBadlyAndInsecurely(param, defaultValue) { |
| return defaultValue; |
| } |
| -var linksToInsert = ExtractGetParameterBadlyAndInsecurely('links_to_insert', 1); |
| -var linksToRemove = ExtractGetParameterBadlyAndInsecurely('links_to_remove', 1); |
| +var numLinksToInsert = |
| + ExtractGetParameterBadlyAndInsecurely('links_to_insert', 1); |
|
mmenke
2012/12/17 20:47:53
nit: 4 space indent.
gavinp
2012/12/17 21:23:23
Done.
|
| -function RemoveLinkElementsAndNavigate() { |
| - for (var i = 1; i <= linksToRemove; ++i) { |
| - var link = document.getElementById('prerenderElement' + i); |
| - link.parentElement.removeChild(link); |
| - } |
| - document.location = 'REPLACE_WITH_DESTINATION_URL'; |
| +var receivedPrerenderStartEvents = []; |
| +var receivedPrerenderStopEvents = []; |
| + |
| +function PrerenderStartHandlerForLink(index) { |
| + receivedPrerenderStartEvents[index] = true; |
| +} |
| + |
| +function PrerenderStopHandlerForLink(index) { |
| + receivedPrerenderStopEvents[index] = true; |
| } |
| -</script> |
| +function RemoveLinkElement(index) { |
| + var link = document.getElementById('prerenderElement' + index); |
| + link.parentElement.removeChild(link); |
| +} |
| +</script> |
| </head> |
| <body> |
| +<p id=paragraph></p> |
|
mmenke
2012/12/17 20:47:53
Is this needed? I don't mind, just don't see it b
gavinp
2012/12/17 21:23:23
No, that's leftover from a debug session. Now cut.
|
| <script> |
| -for (var i = 1; i <= linksToInsert; ++i) { |
| +for (var i = 0; i < numLinksToInsert; ++i) { |
| document.write( |
| '<link id="prerenderElement' + i + |
| '" rel="prerender" href="REPLACE_WITH_PRERENDER_URL"/>'); |
| + var link = document.getElementById('prerenderElement' + i); |
| + link.addEventListener('webkitprerenderstart', |
| + PrerenderStartHandlerForLink.bind(null, i), false); |
| + link.addEventListener('webkitprerenderstop', |
| + PrerenderStopHandlerForLink.bind(null, i), false); |
|
mmenke
2012/12/17 20:47:53
nit: Replace tabs with spaces.
gavinp
2012/12/17 21:23:23
Done.
|
| } |
| </script> |
| -<a href="REPLACE_WITH_DESTINATION_URL">Link To Click</a> |
| +<a id="toClick" href="REPLACE_WITH_DESTINATION_URL">Link To Click For First Prerender</a> |
| </body> |
| </html> |
