Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1145893010: Gallery: Add toolbar at the top of window. (Closed)

Created:
5 years, 6 months ago by yawano
Modified:
5 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Add toolbar at the top of window. BUG=488227 TEST=Manually tested. Committed: https://crrev.com/abd18063e7b78bc50db62c1914aa729cb0daa40f Cr-Commit-Position: refs/heads/master@{#332346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -29 lines) Patch
M ui/file_manager/gallery/css/gallery.css View 3 chunks +11 lines, -5 lines 0 comments Download
M ui/file_manager/gallery/gallery.html View 2 chunks +7 lines, -5 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 7 chunks +12 lines, -7 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 10 chunks +23 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
yawano
PTAL. Thank you!
5 years, 6 months ago (2015-06-02 04:19:21 UTC) #2
fukino
lgtm!
5 years, 6 months ago (2015-06-02 04:40:36 UTC) #3
yawano
On 2015/06/02 04:40:36, fukino wrote: > lgtm! Thank you!
5 years, 6 months ago (2015-06-02 04:42:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145893010/1
5 years, 6 months ago (2015-06-02 04:42:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 05:21:33 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abd18063e7b78bc50db62c1914aa729cb0daa40f Cr-Commit-Position: refs/heads/master@{#332346}
5 years, 6 months ago (2015-06-02 05:22:29 UTC) #8
yawano
5 years, 6 months ago (2015-06-10 04:27:59 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1170403005/ by yawano@chromium.org.

The reason for reverting is: All of Gallery Material Redesign will happen in
M46..

Powered by Google App Engine
This is Rietveld 408576698