content/renderer/pepper/ppb_image_data_impl.h - Issue 1145893009: Change transport dib API to not make copies of SharedMemoryHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/ppb_image_data_impl.h

Issue 1145893009: Change transport dib API to not make copies of SharedMemoryHandle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared_memory_pepper_rename

Patch Set: Comments from jbauman. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/ppb_image_data_impl.h

diff --git a/content/renderer/pepper/ppb_image_data_impl.h b/content/renderer/pepper/ppb_image_data_impl.h

index c8519f40fd59f8aca1175e9a9504a4a958bf8439..b7a4540150cd5cbb0df42d6b5da883b7ca584562 100644

--- a/content/renderer/pepper/ppb_image_data_impl.h

+++ b/content/renderer/pepper/ppb_image_data_impl.h

@@ -46,7 +46,7 @@ class CONTENT_EXPORT PPB_ImageData_Impl

virtual TransportDIB* GetTransportDIB() const = 0;

virtual void* Map() = 0;

virtual void Unmap() = 0;

- virtual int32_t GetSharedMemory(base::SharedMemoryHandle* handle,

+ virtual int32_t GetSharedMemory(base::SharedMemory** shm,

uint32_t* byte_count) = 0;

virtual SkCanvas* GetPlatformCanvas() = 0;

virtual SkCanvas* GetCanvas() = 0;

@@ -92,7 +92,7 @@ class CONTENT_EXPORT PPB_ImageData_Impl

PP_Bool Describe(PP_ImageDataDesc* desc) override;

void* Map() override;

void Unmap() override;

- int32_t GetSharedMemory(base::SharedMemoryHandle* handle,

+ int32_t GetSharedMemory(base::SharedMemory** shm,

uint32_t* byte_count) override;

SkCanvas* GetPlatformCanvas() override;

SkCanvas* GetCanvas() override;

@@ -128,7 +128,7 @@ class ImageDataPlatformBackend : public PPB_ImageData_Impl::Backend {

TransportDIB* GetTransportDIB() const override;

void* Map() override;

void Unmap() override;

- int32_t GetSharedMemory(base::SharedMemoryHandle* handle,

+ int32_t GetSharedMemory(base::SharedMemory** shm,

uint32_t* byte_count) override;

SkCanvas* GetPlatformCanvas() override;

SkCanvas* GetCanvas() override;

@@ -162,7 +162,7 @@ class ImageDataSimpleBackend : public PPB_ImageData_Impl::Backend {

TransportDIB* GetTransportDIB() const override;

void* Map() override;

void Unmap() override;

- int32_t GetSharedMemory(base::SharedMemoryHandle* handle,

+ int32_t GetSharedMemory(base::SharedMemory** shm,

uint32_t* byte_count) override;

SkCanvas* GetPlatformCanvas() override;

SkCanvas* GetCanvas() override;

« no previous file with comments | « content/renderer/pepper/pepper_video_source_host.cc ('k') | content/renderer/pepper/ppb_image_data_impl.cc » ('j') | no next file with comments »