Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 1145893003: [crankshaft] Record inlined shared function infos instead of closures. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Record inlined shared function infos instead of closures. The list of inlined functions is used in exactly two places - for live edit and to prevent code flushing for inlined functions - and those are fine with SharedFunctionInfo and don't require a closure. This is one additional step towards inlining based on SharedFunctionInfo instead of JSFunction. R=jarin@chromium.org Committed: https://crrev.com/388e791df91c299507d62f91bc4f618a4dc80276 Cr-Commit-Position: refs/heads/master@{#28672}

Patch Set 1 #

Patch Set 2 : Fix test failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -102 lines) Patch
M src/arm/lithium-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +3 lines, -10 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 1 chunk +3 lines, -8 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +7 lines, -9 lines 0 comments Download
M src/hydrogen-instructions.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +3 lines, -10 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/lithium.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/lithium.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 1 chunk +15 lines, -16 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +3 lines, -10 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 1 chunk +3 lines, -10 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +3 lines, -10 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-05-28 06:06:04 UTC) #1
Benedikt Meurer
Hey Jaro, This is the fix for Crankshaft. TurboFan currently always sets inlined function count ...
5 years, 6 months ago (2015-05-28 06:07:01 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-05-28 06:52:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145893003/20001
5 years, 6 months ago (2015-05-28 06:54:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-28 07:11:58 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 07:12:15 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/388e791df91c299507d62f91bc4f618a4dc80276
Cr-Commit-Position: refs/heads/master@{#28672}

Powered by Google App Engine
This is Rietveld 408576698