Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 1145893002: Add a test for requesting mount via a context menu in Files app. (Closed)

Created:
5 years, 7 months ago by mtomasz
Modified:
5 years, 7 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for requesting mount via a context menu in Files app. TEST=browser_tests: *Providers/FileSystemBrowserTest* BUG=486864 Committed: https://crrev.com/9a5d26bf93bc0a715b8b201668ae084a6d1bd458 Cr-Commit-Position: refs/heads/master@{#330715}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -11 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 2 4 chunks +24 lines, -4 lines 0 comments Download
A ui/file_manager/integration_tests/file_manager/providers.js View 1 1 chunk +75 lines, -0 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager_test_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
A ui/file_manager/integration_tests/testing_provider/background.js View 1 chunk +47 lines, -0 lines 0 comments Download
A + ui/file_manager/integration_tests/testing_provider/manifest.json View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mtomasz
@yawano: PTAL. Thanks!
5 years, 7 months ago (2015-05-20 01:30:37 UTC) #2
yawano
https://codereview.chromium.org/1145893002/diff/1/ui/file_manager/integration_tests/file_manager/providers.js File ui/file_manager/integration_tests/file_manager/providers.js (right): https://codereview.chromium.org/1145893002/diff/1/ui/file_manager/integration_tests/file_manager/providers.js#newcode50 ui/file_manager/integration_tests/file_manager/providers.js:50: remoteCall.waitForElement( Why you wait the element two times here?
5 years, 7 months ago (2015-05-20 02:53:11 UTC) #3
mtomasz
https://codereview.chromium.org/1145893002/diff/1/ui/file_manager/integration_tests/file_manager/providers.js File ui/file_manager/integration_tests/file_manager/providers.js (right): https://codereview.chromium.org/1145893002/diff/1/ui/file_manager/integration_tests/file_manager/providers.js#newcode50 ui/file_manager/integration_tests/file_manager/providers.js:50: remoteCall.waitForElement( On 2015/05/20 02:53:11, yawano wrote: > Why you ...
5 years, 7 months ago (2015-05-20 04:26:58 UTC) #4
yawano
lgtm. Thank you!
5 years, 7 months ago (2015-05-20 04:58:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145893002/20001
5 years, 7 months ago (2015-05-20 06:23:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/26738) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-20 06:26:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145893002/40001
5 years, 7 months ago (2015-05-20 08:29:08 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 08:54:03 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 08:55:00 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9a5d26bf93bc0a715b8b201668ae084a6d1bd458
Cr-Commit-Position: refs/heads/master@{#330715}

Powered by Google App Engine
This is Rietveld 408576698