Issue 1145883002: Don't pointerify [☺] User Name nor user@name.com In the top, right corner of chrome://apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1145883002: Don't pointerify [☺] User Name nor user@name.com In the top, right corner of chrome://apps. (Closed)

Created:
5 years, 7 months ago by Dan Beam

Modified:
5 years, 7 months ago

Reviewers:
Jeremy Klein

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Don't pointerify [☺] User Name nor user@example.com in the top, right corner of chrome://apps[1]. It looks like clicking this should do something. It doesn't. R=jlklein@chromium.org BUG=none [1] http://i.imgur.com/FYEggUl.png Committed: https://crrev.com/46051f4bbc51f9c66b8581887384d7945d101a6b Cr-Commit-Position: refs/heads/master@{#330776}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/resources/ntp4/new_tab.css	View		2 chunks	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/resources/ntp4/new_tab.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145883002/1

5 years, 7 months ago (2015-05-20 17:39:53 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 18:34:44 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/46051f4bbc51f9c66b8581887384d7945d101a6b
Cr-Commit-Position: refs/heads/master@{#330776}