core/src/fxge/win32/fx_win32_print.cpp - Issue 1145843005: Revert "Remove FX_Alloc() null checks now that it can't return NULL."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/win32/fx_win32_print.cpp

Issue 1145843005: Revert "Remove FX_Alloc() null checks now that it can't return NULL." (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxge/win32/fx_win32_print.cpp

diff --git a/core/src/fxge/win32/fx_win32_print.cpp b/core/src/fxge/win32/fx_win32_print.cpp

index 670622a5fb36e79a8cecd277ccbc99b6028e361b..7dc48a1808f25922ff3bdc160554d1a4ee6ca305 100644

--- a/core/src/fxge/win32/fx_win32_print.cpp

+++ b/core/src/fxge/win32/fx_win32_print.cpp

@@ -295,6 +295,9 @@ FX_BOOL CPSPrinterDriver::Init(HDC hDC, int pslevel, FX_BOOL bCmykOutput)

ret = ::GetRegionData(hRgn, 0, NULL);

if (ret) {

RGNDATA* pData = (RGNDATA*)FX_Alloc(FX_BYTE, ret);

+ if (!pData) {

+ return FALSE;

+ }

ret = ::GetRegionData(hRgn, ret, pData);

if (ret) {

CFX_PathData path;

« no previous file with comments | « core/src/fxge/win32/fx_win32_gdipext.cpp ('k') | fpdfsdk/src/fsdk_baseform.cpp » ('j') | no next file with comments »