Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: core/src/fxcrt/xml_int.h

Issue 1145843005: Revert "Remove FX_Alloc() null checks now that it can't return NULL." (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/src/fxcrt/fxcrt_posix.cpp ('k') | core/src/fxge/agg/agg23/agg_array.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fxcrt/xml_int.h
diff --git a/core/src/fxcrt/xml_int.h b/core/src/fxcrt/xml_int.h
index f0a2485163aed673e0f41af4447b7f455c10ec26..964c7944d178024fe62de2565cb2b97f3b685b17 100644
--- a/core/src/fxcrt/xml_int.h
+++ b/core/src/fxcrt/xml_int.h
@@ -107,6 +107,9 @@ public:
m_dwSize = (size_t)FX_MIN(FX_XMLDATASTREAM_BufferSize, nLength - m_nStart);
if (!m_pBuffer) {
m_pBuffer = FX_Alloc(FX_BYTE, m_dwSize);
+ if (!m_pBuffer) {
+ return FALSE;
+ }
}
return m_pFileRead->ReadBlock(m_pBuffer, m_nStart, m_dwSize);
}
« no previous file with comments | « core/src/fxcrt/fxcrt_posix.cpp ('k') | core/src/fxge/agg/agg23/agg_array.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698