core/src/fxcrt/fx_basic_bstring.cpp - Issue 1145843005: Revert "Remove FX_Alloc() null checks now that it can't return NULL."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_basic_bstring.cpp

Issue 1145843005: Revert "Remove FX_Alloc() null checks now that it can't return NULL." (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxcrt/fx_basic_bstring.cpp

diff --git a/core/src/fxcrt/fx_basic_bstring.cpp b/core/src/fxcrt/fx_basic_bstring.cpp

index 2377a6d624ae9e5ebb01c17563c8360e69c64202..781b821f0041760d46ae0640234caaf0e2564502 100644

--- a/core/src/fxcrt/fx_basic_bstring.cpp

+++ b/core/src/fxcrt/fx_basic_bstring.cpp

@@ -73,6 +73,9 @@ CFX_ByteString::StringData* CFX_ByteString::StringData::Create(int nLen)

FXSYS_assert(usableSize >= nLen);

void* pData = FX_Alloc(FX_BYTE, totalSize);

+ if (!pData) {

+ return NULL;

+ }

return new (pData) StringData(nLen, usableSize);

}

CFX_ByteString::~CFX_ByteString()

« no previous file with comments | « core/src/fxcrt/fx_basic_array.cpp ('k') | core/src/fxcrt/fx_basic_buffer.cpp » ('j') | no next file with comments »