core/src/fxcodec/codec/fx_codec.cpp - Issue 1145843005: Revert "Remove FX_Alloc() null checks now that it can't return NULL."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcodec/codec/fx_codec.cpp

Issue 1145843005: Revert "Remove FX_Alloc() null checks now that it can't return NULL." (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxcodec/codec/fx_codec.cpp

diff --git a/core/src/fxcodec/codec/fx_codec.cpp b/core/src/fxcodec/codec/fx_codec.cpp

index c325cccdd4e868a5bdc88f6659f59bbf585b2f41..e8aad711f3e6611d8c94ee5969d69ea7f05ffe24 100644

--- a/core/src/fxcodec/codec/fx_codec.cpp

+++ b/core/src/fxcodec/codec/fx_codec.cpp

@@ -333,6 +333,9 @@ FX_BOOL CCodec_RLScanlineDecoder::Create(FX_LPCBYTE src_buf, FX_DWORD src_size,

m_Pitch = (width * nComps * bpc + 31) / 32 * 4;

m_dwLineBytes = (width * nComps * bpc + 7) / 8;

m_pScanline = FX_Alloc(FX_BYTE, m_Pitch);

+ if (m_pScanline == NULL) {

+ return FALSE;

+ }

return CheckDestSize();

}

FX_BOOL CCodec_RLScanlineDecoder::v_Rewind()

« no previous file with comments | « core/src/fpdftext/fpdf_text_int.cpp ('k') | core/src/fxcodec/codec/fx_codec_fax.cpp » ('j') | no next file with comments »