Revert "Remove FX_Alloc() null checks now that it can't return NULL."

core/src/fxge/dib/fx_dib_convert.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxge/fx_dib.h"
 #include "../../../include/fxge/fx_ge.h"
 #include "../../../include/fxcodec/fx_codec.h"
 const FX_DWORD g_dwWinPalette[256] = {
@@ skipping 218 matching lines @@
 }
 FX_BOOL CFX_Palette::BuildPalette(const CFX_DIBSource* pBitmap, int pal_type)
 {
     if (pBitmap == NULL) {
         return FALSE;
     }
     if (m_pPalette != NULL) {
         FX_Free(m_pPalette);
     }
     m_pPalette = FX_Alloc(FX_DWORD, 256);
+    if (!m_pPalette) {
+        return FALSE;
+    }
     int bpp    = pBitmap->GetBPP() / 8;
     int width  = pBitmap->GetWidth();
     int height = pBitmap->GetHeight();
     if (m_cLut) {
         FX_Free(m_cLut);
         m_cLut = NULL;
     }
     if (m_aLut) {
         FX_Free(m_aLut);
         m_aLut = NULL;
     }
     m_cLut = FX_Alloc(FX_DWORD, 4096);
+    if (!m_cLut) {
+        return FALSE;
+    }
     m_aLut = FX_Alloc(FX_DWORD, 4096);
+    if (!m_aLut) {
+        return FALSE;
+    }
     int row, col;
     m_lut = 0;
     for (row = 0; row < height; row++) {
         FX_BYTE* scan_line = (FX_BYTE*)pBitmap->GetScanline(row);
         for (col = 0; col < width; col++) {
             FX_BYTE* src_port = scan_line + col * bpp;
             FX_DWORD b = src_port[0] & 0xf0;
             FX_DWORD g = src_port[1] & 0xf0;
             FX_DWORD r = src_port[2] & 0xf0;
             FX_DWORD index = (r << 4) + g + (b >> 4);
@@ skipping 590 matching lines @@
                     return _ConvertBuffer_RgbOrCmyk2Gray(dest_buf, dest_pitch, width, height, pSrcBitmap, src_left, src_top, pIccTransform);
                 }
                 return FALSE;
             }
         case FXDIB_8bppRgb:
         case FXDIB_8bppRgba: {
                 if ((src_format & 0xff) == 8 && pSrcBitmap->GetPalette() == NULL) {
                     return ConvertBuffer(FXDIB_8bppMask, dest_buf, dest_pitch, width, height, pSrcBitmap, src_left, src_top, d_pal, pIccTransform);
                 }
                 d_pal = FX_Alloc(FX_DWORD, 256);
+                if (!d_pal) {
+                    return FALSE;
+                }
                 if (((src_format & 0xff) == 1 || (src_format & 0xff) == 8) && pSrcBitmap->GetPalette()) {
                     return _ConvertBuffer_Plt2PltRgb8(dest_buf, dest_pitch, width, height, pSrcBitmap, src_left, src_top, d_pal, pIccTransform);
                 } else if ((src_format & 0xff) >= 24) {
                     return _ConvertBuffer_Rgb2PltRgb8(dest_buf, dest_pitch, width, height, pSrcBitmap, src_left, src_top, d_pal, pIccTransform);
                 }
                 return FALSE;
             }
         case FXDIB_Rgb:
         case FXDIB_Rgba: {
                 if ((src_format & 0xff) == 1) {
@@ skipping 187 matching lines @@
     if (!m_bExtBuf) {
         FX_Free(m_pBuffer);
     }
     m_bExtBuf = FALSE;
     m_pBuffer = dest_buf;
     m_bpp = (FX_BYTE)dest_format;
     m_AlphaFlag = (FX_BYTE)(dest_format >> 8);
     m_Pitch = dest_pitch;
     return TRUE;
 }