Revert "Remove FX_Alloc() null checks now that it can't return NULL."

core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_parser.h"
 #include "../../../include/fxcrt/fx_string.h"
 
 //static
@@ skipping 1068 matching lines @@
         m_pData = (FX_LPBYTE)pStream->m_pDataBuf;
         return;
     }
     FX_LPBYTE pSrcData;
     FX_DWORD dwSrcSize = pStream->m_dwSize;
     if (dwSrcSize == 0) {
         return;
     }
     if (!pStream->IsMemoryBased()) {
         pSrcData = m_pSrcData = FX_Alloc(FX_BYTE, dwSrcSize);
-        if (!pStream->ReadRawData(0, pSrcData, dwSrcSize)) {
+        if (!pSrcData || !pStream->ReadRawData(0, pSrcData, dwSrcSize)) {
             return;
         }
     } else {
         pSrcData = pStream->m_pDataBuf;
     }
     FX_LPBYTE pDecryptedData;
     FX_DWORD dwDecryptedSize;
     if (pStream->m_pCryptoHandler) {
         CFX_BinaryBuf dest_buf;
         dest_buf.EstimateSize(pStream->m_pCryptoHandler->DecryptGetSize(dwSrcSize));
@@ skipping 58 matching lines @@
 }
 FX_LPBYTE CPDF_StreamAcc::DetachData()
 {
     if (m_bNewBuf) {
         FX_LPBYTE p = m_pData;
         m_pData = NULL;
         m_dwSize = 0;
         return p;
     }
     FX_LPBYTE p = FX_Alloc(FX_BYTE, m_dwSize);
+    if (p == NULL) {
+        return NULL;
+    }
     FXSYS_memcpy32(p, m_pData, m_dwSize);
     return p;
 }
 void CPDF_Reference::SetRef(CPDF_IndirectObjects* pDoc, FX_DWORD objnum)
 {
     m_pObjList = pDoc;
     m_RefObjNum = objnum;
 }
 CPDF_IndirectObjects::CPDF_IndirectObjects(IPDF_DocParser* pParser)
 {
@@ skipping 101 matching lines @@
     pObj->m_ObjNum = objnum;
     m_IndirectObjs.SetAt((FX_LPVOID)(FX_UINTPTR)objnum, pObj);
     if (m_LastObjNum < objnum) {
         m_LastObjNum = objnum;
     }
 }
 FX_DWORD CPDF_IndirectObjects::GetLastObjNum() const
 {
     return m_LastObjNum;
 }