Revert "Remove FX_Alloc() null checks now that it can't return NULL."

core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "../../../include/fxcodec/fx_codec.h"
 #include "pageint.h"
@@ skipping 244 matching lines @@
     }
     int ncomps = pDecoder->CountComps();
     int bpc = pDecoder->GetBPC();
     int width = pDecoder->GetWidth();
     int height = pDecoder->GetHeight();
     int pitch = (width * ncomps * bpc + 7) / 8;
     if (height == 0 || pitch > (1 << 30) / height) {
         delete pDecoder;
         return -1;
     }
-    dest_buf = FX_Alloc2D(FX_BYTE, pitch, height);
-    dest_size = pitch * height;  // Safe since checked alloc returned.
+    dest_size = pitch * height;
+    dest_buf = FX_Alloc( FX_BYTE, dest_size);
     for (int row = 0; row < height; row ++) {
         FX_LPBYTE pLine = pDecoder->GetScanline(row);
         if (pLine == NULL) {
             break;
         }
         FXSYS_memcpy32(dest_buf + row * pitch, pLine, pitch);
     }
     FX_DWORD srcoff = pDecoder->GetSrcOffset();
     delete pDecoder;
     return srcoff;
@@ skipping 766 matching lines @@
                     FX_DWORD i;
                     for (i = 0; i < m_nStreams; i ++) {
                         FX_DWORD size = m_pStreamArray[i]->GetSize();
                         if (m_Size + size + 1 <= m_Size) {
                             m_Status = Done;
                             return;
                         }
                         m_Size += size + 1;
                     }
                     m_pData = FX_Alloc(FX_BYTE, m_Size);
+                    if (!m_pData) {
+                        m_Status = Done;
+                        return;
+                    }
                     FX_DWORD pos = 0;
                     for (i = 0; i < m_nStreams; i ++) {
                         FXSYS_memcpy32(m_pData + pos, m_pStreamArray[i]->GetData(), m_pStreamArray[i]->GetSize());
                         pos += m_pStreamArray[i]->GetSize() + 1;
                         m_pData[pos - 1] = ' ';
                         delete m_pStreamArray[i];
                     }
                     FX_Free(m_pStreamArray);
                     m_pStreamArray = NULL;
                 } else {
@@ skipping 78 matching lines @@
         return 100;
     }
     if (m_InternalStage == PAGEPARSE_STAGE_GETCONTENT) {
         return 10;
     }
     if (m_InternalStage == PAGEPARSE_STAGE_CHECKCLIP) {
         return 90;
     }
     return 10 + 80 * m_CurrentOffset / m_Size;
 }