Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1145843002: Fix domokit.github.io site deployment script (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -158 lines) Patch
D mojo/tools/deploy.py View 1 chunk +0 lines, -134 lines 0 comments Download
A + mojo/tools/deploy_domokit_site.py View 1 2 6 chunks +42 lines, -23 lines 0 comments Download
M sky/examples/raw/touch-demo.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 7 months ago (2015-05-19 20:48:43 UTC) #2
eseidel
lgtm https://codereview.chromium.org/1145843002/diff/1/mojo/tools/deploy_domokit_site.py File mojo/tools/deploy_domokit_site.py (right): https://codereview.chromium.org/1145843002/diff/1/mojo/tools/deploy_domokit_site.py#newcode111 mojo/tools/deploy_domokit_site.py:111: if not os.path.isdir(icons_dir): Seems easier to just run ...
5 years, 7 months ago (2015-05-19 20:51:13 UTC) #3
Cutch
https://codereview.chromium.org/1145843002/diff/1/mojo/tools/deploy_domokit_site.py File mojo/tools/deploy_domokit_site.py (right): https://codereview.chromium.org/1145843002/diff/1/mojo/tools/deploy_domokit_site.py#newcode111 mojo/tools/deploy_domokit_site.py:111: if not os.path.isdir(icons_dir): On 2015/05/19 20:51:12, eseidel wrote: > ...
5 years, 7 months ago (2015-05-19 21:01:53 UTC) #4
Cutch
5 years, 7 months ago (2015-05-19 21:03:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c1795b1c52c84c9499c170bed62113f0f71a0e64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698