Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: chrome/browser/ui/ash/cast_config_delegate_chromeos.cc

Issue 1145833003: Allow the cast tray to function as expected when the installed extension is missing API methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Previous patch somehow messed up the changed files Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/cast_config_delegate_chromeos.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/cast_config_delegate_chromeos.cc
diff --git a/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc b/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc
index 3f0b87bf5b0e8c360b6715cb9009a6aa0535477c..7f5838c5452ada6d10f6758aa1765f2d37698523 100644
--- a/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc
+++ b/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc
@@ -138,8 +138,13 @@ void CastConfigDelegateChromeos::CastToReceiver(
"');");
}
-void CastConfigDelegateChromeos::StopCasting(const std::string& activity_id) {
+void CastConfigDelegateChromeos::StopCasting() {
ExecuteJavaScript("backgroundSetup.stopCastMirroring('user-stop');");
+
+ // TODO(jdufault): Remove this after stopCasting is properly exported. The
achuithb 2015/05/19 23:57:10 Please file a bug to track this.
jdufault 2015/05/20 00:02:19 Done.
+ // current beta/release versions of the cast extension do not export
+ // stopCastMirroring, so we will also try to call the mangled version.
achuithb 2015/05/19 23:57:10 s/mangled/minified
jdufault 2015/05/20 00:02:19 Done.
+ ExecuteJavaScript("backgroundSetup.Qu('user-stop');");
}
void CastConfigDelegateChromeos::LaunchCastOptions() {
« no previous file with comments | « chrome/browser/ui/ash/cast_config_delegate_chromeos.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698