Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1145833003: Allow the cast tray to function as expected when the installed extension is missing API methods. (Closed)

Created:
5 years, 7 months ago by jdufault
Modified:
5 years, 7 months ago
Reviewers:
achuithb, oshima, jennyz
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow the cast tray to function as expected when the installed extension is missing API methods. BUG=489445 Committed: https://crrev.com/1924f747637265f563892b8f56a64391f6208194 Cr-Commit-Position: refs/heads/master@{#330663}

Patch Set 1 #

Patch Set 2 : Reorder localization strings #

Patch Set 3 : Remove LOG statement #

Patch Set 4 : Use a better string for the title #

Patch Set 5 : Previous patch somehow messed up the changed files #

Total comments: 4

Patch Set 6 : Add bug to comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -32 lines) Patch
M ash/ash_strings.grd View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M ash/cast_config_delegate.h View 4 1 chunk +2 lines, -7 lines 0 comments Download
M ash/system/cast/tray_cast.cc View 1 2 3 4 3 chunks +5 lines, -23 lines 0 comments Download
M chrome/browser/ui/ash/cast_config_delegate_chromeos.h View 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/cast_config_delegate_chromeos.cc View 1 2 3 4 5 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
jdufault
5 years, 7 months ago (2015-05-19 21:57:09 UTC) #3
jennyz
lgtm
5 years, 7 months ago (2015-05-19 22:01:02 UTC) #4
achuithb
lgtm
5 years, 7 months ago (2015-05-19 23:32:21 UTC) #5
oshima
lgtm
5 years, 7 months ago (2015-05-19 23:36:37 UTC) #6
oshima
lgtm
5 years, 7 months ago (2015-05-19 23:54:17 UTC) #10
achuithb
https://codereview.chromium.org/1145833003/diff/80001/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc File chrome/browser/ui/ash/cast_config_delegate_chromeos.cc (right): https://codereview.chromium.org/1145833003/diff/80001/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc#newcode144 chrome/browser/ui/ash/cast_config_delegate_chromeos.cc:144: // TODO(jdufault): Remove this after stopCasting is properly exported. ...
5 years, 7 months ago (2015-05-19 23:57:11 UTC) #11
jdufault
https://codereview.chromium.org/1145833003/diff/80001/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc File chrome/browser/ui/ash/cast_config_delegate_chromeos.cc (right): https://codereview.chromium.org/1145833003/diff/80001/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc#newcode144 chrome/browser/ui/ash/cast_config_delegate_chromeos.cc:144: // TODO(jdufault): Remove this after stopCasting is properly exported. ...
5 years, 7 months ago (2015-05-20 00:02:20 UTC) #12
achuithb
lgtm, but please wait for Jenny and Oshima-san
5 years, 7 months ago (2015-05-20 00:03:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145833003/100001
5 years, 7 months ago (2015-05-20 00:22:09 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-20 01:05:43 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 01:07:42 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/1924f747637265f563892b8f56a64391f6208194
Cr-Commit-Position: refs/heads/master@{#330663}

Powered by Google App Engine
This is Rietveld 408576698