Issue 1145823002: Fix shelldb workflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1145823002: Fix shelldb workflow (Closed)

Created:
5 years, 7 months ago by Cutch

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix shelldb workflow - Add a real internals.dart entry point. - Don't run deploy_sdk from shelldb. - Suppress native functions error from analyzer output. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7b66d672f1a662d3c3d1e20e5de15a4af13fb65a

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -19 lines)			Patch
	A +	sky/sdk/lib/internals.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	sky/tools/shelldb	View	1	4 chunks	+35 lines, -16 lines	0 comments	Download

Total messages: 4 (1 generated)

eseidel

lgtm This is only 1 of 4 of the same pathway btw. :) ./sky/tools/skydb (runs ...

5 years, 7 months ago (2015-05-19 16:55:33 UTC) #3

Cutch

5 years, 7 months ago (2015-05-19 17:12:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7b66d672f1a662d3c3d1e20e5de15a4af13fb65a (presubmit successful).