content/renderer/render_widget_fullscreen_pepper.cc - Issue 11458003: Remove scoped_refptr::release which is confusing and causes leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_widget_fullscreen_pepper.cc

Issue 11458003: Remove scoped_refptr::release which is confusing and causes leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix mac Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_widget_fullscreen_pepper.cc

diff --git a/content/renderer/render_widget_fullscreen_pepper.cc b/content/renderer/render_widget_fullscreen_pepper.cc

index 58cb9dae1f98c667a979dddf0c1f5efaca13eaec..a5458ffd40d5aa9cc159889b4ba3b7069f517a54 100644

--- a/content/renderer/render_widget_fullscreen_pepper.cc

+++ b/content/renderer/render_widget_fullscreen_pepper.cc

@@ -352,7 +352,8 @@ RenderWidgetFullscreenPepper* RenderWidgetFullscreenPepper::Create(

scoped_refptr<RenderWidgetFullscreenPepper> widget(

new RenderWidgetFullscreenPepper(plugin, active_url, screen_info));

widget->Init(opener_id);

- return widget.release();

+ widget->AddRef();

+ return widget.get();

}

RenderWidgetFullscreenPepper::RenderWidgetFullscreenPepper(