content/renderer/media/media_stream_dependency_factory.cc - Issue 11458003: Remove scoped_refptr::release which is confusing and causes leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_dependency_factory.cc

Issue 11458003: Remove scoped_refptr::release which is confusing and causes leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: duh Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/media_stream_dependency_factory.cc

diff --git a/content/renderer/media/media_stream_dependency_factory.cc b/content/renderer/media/media_stream_dependency_factory.cc

index a5d60b1ff00d36764fa294e9e00b090d6d861d30..1e55519d06f2f3a3c81f48efb91dce4c6f965832 100644

--- a/content/renderer/media/media_stream_dependency_factory.cc

+++ b/content/renderer/media/media_stream_dependency_factory.cc

@@ -303,7 +303,7 @@ bool MediaStreamDependencyFactory::CreatePeerConnectionFactory() {

signaling_thread_,

audio_device_));

if (factory.get())

- pc_factory_ = factory.release();

+ pc_factory_ = factory;

else

audio_device_ = NULL;

}