Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/extensions/api/page_capture/page_capture_api.cc

Issue 11458003: Remove scoped_refptr::release which is confusing and causes leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: duh Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/page_capture/page_capture_api.cc
diff --git a/chrome/browser/extensions/api/page_capture/page_capture_api.cc b/chrome/browser/extensions/api/page_capture/page_capture_api.cc
index 8c58db6227345d67925340b40508bebe6f6c6b7b..172e931e0306d6da1ee48cad9aa45af8f215594e 100644
--- a/chrome/browser/extensions/api/page_capture/page_capture_api.cc
+++ b/chrome/browser/extensions/api/page_capture/page_capture_api.cc
@@ -44,8 +44,10 @@ PageCaptureSaveAsMHTMLFunction::PageCaptureSaveAsMHTMLFunction() {
PageCaptureSaveAsMHTMLFunction::~PageCaptureSaveAsMHTMLFunction() {
if (mhtml_file_.get()) {
- BrowserThread::ReleaseSoon(BrowserThread::IO, FROM_HERE,
- mhtml_file_.release());
+ webkit_blob::ShareableFileReference* to_release = mhtml_file_.get();
+ to_release->AddRef();
+ mhtml_file_ = NULL;
+ BrowserThread::ReleaseSoon(BrowserThread::IO, FROM_HERE, to_release);
}
}

Powered by Google App Engine
This is Rietveld 408576698