Remove scoped_refptr::release which is confusing and causes leaks.

ui/compositor/layer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/layer.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 391 matching lines @@
   if (fills_bounds_opaquely_ == fills_bounds_opaquely)
     return;
 
   fills_bounds_opaquely_ = fills_bounds_opaquely;
 
   cc_layer_->setContentsOpaque(fills_bounds_opaquely);
 }
 
 void Layer::SetExternalTexture(Texture* texture) {
   DCHECK_EQ(type_, LAYER_TEXTURED);
+  DCHECK(!solid_color_layer_);
   layer_updated_externally_ = !!texture;
   texture_ = texture;
   if (cc_layer_is_accelerated_ != layer_updated_externally_) {
     // Switch to a different type of layer.
     cc_layer_->removeAllChildren();
-    scoped_refptr<cc::ContentLayer> old_content_layer(
-        content_layer_.release());
-    scoped_refptr<cc::SolidColorLayer> old_solid_layer(
-        solid_color_layer_.release());
-    scoped_refptr<cc::TextureLayer> old_texture_layer(
-        texture_layer_.release());
+
+    scoped_refptr<cc::ContentLayer> old_content_layer;
+    old_content_layer.swap(content_layer_);
+    scoped_refptr<cc::TextureLayer> old_texture_layer;
+    old_texture_layer.swap(texture_layer_);
+
     cc::Layer* new_layer = NULL;
     if (layer_updated_externally_) {
       texture_layer_ = cc::TextureLayer::create(this);
       texture_layer_->setFlipped(texture_->flipped());
       new_layer = texture_layer_.get();
     } else {
       old_texture_layer->willModifyTexture();
       content_layer_ = cc::ContentLayer::create(this);
       new_layer = content_layer_.get();
     }
@@ skipping 360 matching lines @@
         0,
         static_cast<float>(size.width())/texture_size.width(),
         static_cast<float>(size.height())/texture_size.height());
     texture_layer_->setUVRect(rect);
 
     cc_layer_->setBounds(ConvertSizeToPixel(this, size));
   }
 }
 
 }  // namespace ui