Remove scoped_refptr::release which is confusing and causes leaks.

net/disk_cache/backend_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/disk_cache/backend_impl.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 794 matching lines @@
   }
 
   // Link this entry through the lists.
   eviction_.OnCreateEntry(cache_entry);
 
   CACHE_UMA(AGE_MS, "CreateTime", 0, start);
   stats_.OnEvent(Stats::CREATE_HIT);
   SIMPLE_STATS_COUNTER("disk_cache.miss");
   Trace("create entry hit ");
   FlushIndex();
-  return cache_entry.release();
+  cache_entry->AddRef();
+  return cache_entry.get();
 }
 
 EntryImpl* BackendImpl::OpenNextEntryImpl(void** iter) {
   return OpenFollowingEntry(true, iter);
 }
 
 EntryImpl* BackendImpl::OpenPrevEntryImpl(void** iter) {
   return OpenFollowingEntry(false, iter);
 }
 
@@ skipping 991 matching lines @@
       if (access_times[i] < access_times[oldest])
         oldest = i;
     }
   }
 
   if (newest < 0 || oldest < 0)
     return NULL;
 
   EntryImpl* next_entry;
   if (forward) {
-    next_entry = entries[newest].release();
+    next_entry = entries[newest].get();
     iterator->list = static_cast<Rankings::List>(newest);
   } else {
-    next_entry = entries[oldest].release();
+    next_entry = entries[oldest].get();
     iterator->list = static_cast<Rankings::List>(oldest);
   }
 
   *iter = iterator.release();
+  next_entry->AddRef();
   return next_entry;
 }
 
 bool BackendImpl::OpenFollowingEntryFromList(bool forward, Rankings::List list,
                                              CacheRankingsBlock** from_entry,
                                              EntryImpl** next_entry) {
   if (disabled_)
     return false;
 
   if (!new_eviction_ && Rankings::NO_USE != list)
@@ skipping 387 matching lines @@
     if (total_memory > kMaxBuffersSize || total_memory <= 0)
       total_memory = kMaxBuffersSize;
 
     done = true;
   }
 
   return static_cast<int>(total_memory);
 }
 
 }  // namespace disk_cache