Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Side by Side Diff: content/renderer/render_widget_fullscreen.cc

Issue 11458003: Remove scoped_refptr::release which is confusing and causes leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mac Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_widget_fullscreen.h" 5 #include "content/renderer/render_widget_fullscreen.h"
6 6
7 #include "content/common/view_messages.h" 7 #include "content/common/view_messages.h"
8 #include "third_party/WebKit/Source/WebKit/chromium/public/WebWidget.h" 8 #include "third_party/WebKit/Source/WebKit/chromium/public/WebWidget.h"
9 9
10 using WebKit::WebWidget; 10 using WebKit::WebWidget;
11 11
12 namespace content { 12 namespace content {
13 13
14 // static
15 RenderWidgetFullscreen* RenderWidgetFullscreen::Create(int32 opener_id) {
16 DCHECK_NE(MSG_ROUTING_NONE, opener_id);
17 scoped_refptr<RenderWidgetFullscreen> widget(
18 new RenderWidgetFullscreen(WebKit::WebScreenInfo()));
19 widget->Init(opener_id);
20 return widget.release();
21 }
22
23 void RenderWidgetFullscreen::show(WebKit::WebNavigationPolicy) { 14 void RenderWidgetFullscreen::show(WebKit::WebNavigationPolicy) {
24 DCHECK(!did_show_) << "received extraneous Show call"; 15 DCHECK(!did_show_) << "received extraneous Show call";
25 DCHECK_NE(MSG_ROUTING_NONE, routing_id_); 16 DCHECK_NE(MSG_ROUTING_NONE, routing_id_);
26 DCHECK_NE(MSG_ROUTING_NONE, opener_id_); 17 DCHECK_NE(MSG_ROUTING_NONE, opener_id_);
27 18
28 if (!did_show_) { 19 if (!did_show_) {
29 did_show_ = true; 20 did_show_ = true;
30 Send(new ViewHostMsg_ShowFullscreenWidget(opener_id_, routing_id_)); 21 Send(new ViewHostMsg_ShowFullscreenWidget(opener_id_, routing_id_));
31 SetPendingWindowRect(initial_pos_); 22 SetPendingWindowRect(initial_pos_);
32 } 23 }
(...skipping 15 matching lines...) Expand all
48 DCHECK(!webwidget_); 39 DCHECK(!webwidget_);
49 40
50 RenderWidget::DoInit( 41 RenderWidget::DoInit(
51 opener_id, 42 opener_id,
52 CreateWebWidget(), 43 CreateWebWidget(),
53 new ViewHostMsg_CreateFullscreenWidget( 44 new ViewHostMsg_CreateFullscreenWidget(
54 opener_id, &routing_id_, &surface_id_)); 45 opener_id, &routing_id_, &surface_id_));
55 } 46 }
56 47
57 } // namespace content 48 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698