Remove scoped_refptr::release which is confusing and causes leaks.

chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
@@ skipping 450 matching lines @@
   extension_function_test_utils::RunFunctionFlags GetFlags() {
     return current_browser()->profile()->IsOffTheRecord() ?
            extension_function_test_utils::INCLUDE_INCOGNITO :
            extension_function_test_utils::NONE;
   }
 
   // extension_function_test_utils::RunFunction*() only uses browser for its
   // profile(), so pass it the on-record browser so that it always uses the
   // on-record profile to match real-life behavior.
 
-  base::Value* RunFunctionAndReturnResult(UIThreadExtensionFunction* function,
-                                          const std::string& args) {
-    scoped_refptr<UIThreadExtensionFunction> delete_function(function);
-    SetUpExtensionFunction(function);
+  base::Value* RunFunctionAndReturnResult(
+      scoped_refptr<UIThreadExtensionFunction> function,
+      const std::string& args) {
+    SetUpExtensionFunction(function.get());
     return extension_function_test_utils::RunFunctionAndReturnSingleResult(
-        function, args, browser(), GetFlags());
+        function.get(), args, browser(), GetFlags());
   }
 
-  std::string RunFunctionAndReturnError(UIThreadExtensionFunction* function,
-                                        const std::string& args) {
-    scoped_refptr<UIThreadExtensionFunction> delete_function(function);
-    SetUpExtensionFunction(function);
+  std::string RunFunctionAndReturnError(
+      scoped_refptr<UIThreadExtensionFunction> function,
+      const std::string& args) {
+    SetUpExtensionFunction(function.get());
     return extension_function_test_utils::RunFunctionAndReturnError(
-        function, args, browser(), GetFlags());
+        function.get(), args, browser(), GetFlags());
   }
 
-  bool RunFunctionAndReturnString(UIThreadExtensionFunction* function,
-                                  const std::string& args,
-                                  std::string* result_string) {
-    SetUpExtensionFunction(function);
+  bool RunFunctionAndReturnString(
+      scoped_refptr<UIThreadExtensionFunction> function,
+      const std::string& args,
+      std::string* result_string) {
+    SetUpExtensionFunction(function.get());
     scoped_ptr<base::Value> result(RunFunctionAndReturnResult(function, args));
     EXPECT_TRUE(result.get());
     return result.get() && result->GetAsString(result_string);
   }
 
   std::string DownloadItemIdAsArgList(const DownloadItem* download_item) {
     return base::StringPrintf("[%d]", download_item->GetId());
   }
 
   const FilePath& downloads_directory() {
@@ skipping 374 matching lines @@
   EXPECT_STREQ(download_extension_errors::kInvalidOperationError,
                error.c_str());
 
   // Calling resume on a non-existent download yields kInvalidOperationError
   error = RunFunctionAndReturnError(
       new DownloadsResumeFunction(), "[-42]");
   EXPECT_STREQ(download_extension_errors::kInvalidOperationError,
                error.c_str());
 }
 
-UIThreadExtensionFunction* MockedGetFileIconFunction(
+scoped_refptr<UIThreadExtensionFunction> MockedGetFileIconFunction(
     const FilePath& expected_path,
     IconLoader::IconSize icon_size,
     const std::string& response) {
   scoped_refptr<DownloadsGetFileIconFunction> function(
       new DownloadsGetFileIconFunction());
   function->SetIconExtractorForTesting(new MockIconExtractorImpl(
       expected_path, icon_size, response));
-  return function.release();
+  return function;
 }
 
 // Test downloads.getFileIcon() on in-progress, finished, cancelled and deleted
 // download items.
 IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,
     DownloadExtensionTest_FileIcon_Active) {
   DownloadItem* download_item = CreateSlowTestDownload();
   ASSERT_TRUE(download_item);
   ASSERT_FALSE(download_item->GetTargetFilePath().empty());
   std::string args32(base::StringPrintf("[%d, {\"size\": 32}]",
@@ skipping 1169 matching lines @@
                           "  \"state\": {"
                           "    \"previous\": \"in_progress\","
                           "    \"current\": \"complete\"}}]",
                           result_id,
                           GetFilename("on_record.txt.crdownload").c_str(),
                           GetFilename("on_record.txt").c_str())));
   std::string disk_data;
   EXPECT_TRUE(file_util::ReadFileToString(item->GetFullPath(), &disk_data));
   EXPECT_STREQ(kPayloadData, disk_data.c_str());
 }