Remove scoped_refptr::release which is confusing and causes leaks.

cc/occlusion_tracker_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/occlusion_tracker.h"
 
 #include <public/WebFilterOperation.h>
 #include <public/WebFilterOperations.h>
 
 #include "cc/layer.h"
@@ skipping 116 matching lines @@
     typedef OcclusionTracker OcclusionTrackerType;
 
     static LayerPtrType createLayer()
     {
         return Layer::create();
     }
     static ContentLayerPtrType createContentLayer() { return make_scoped_refptr(new ContentLayerType()); }
 
     static LayerPtrType passLayerPtr(ContentLayerPtrType& layer)
     {
-        return layer.release();
+        LayerPtrType ref(layer);
+        layer = NULL;

[danakj, 2012/12/06 05:00:09]

The NULL assignment seems unneeded. The callsite will hold the ref and release
it without this. Can't this just "return LayerPtrType(layer);"?

[piman, 2012/12/06 05:16:00]

I wanted to keep the semantics that it cleared the passed parameter. This is
what happens on the impl thread versions as well. But you're right that the
current call sites don't rely on it. I don't feel strongly either way.

+        return ref;
     }
 
     static LayerPtrType passLayerPtr(LayerPtrType& layer)
     {
-        return layer.release();
+        LayerPtrType ref(layer);
+        layer = NULL;
+        return ref;
     }
 
     static void destroyLayer(LayerPtrType& layer)
     {
         layer = NULL;
     }
 };
 
 struct OcclusionTrackerTestImplThreadTypes {
     typedef LayerImpl LayerType;
@@ skipping 2920 matching lines @@
 
         EXPECT_EQ(gfx::Rect(gfx::Point(), trackingSize).ToString(), occlusion.occlusionInScreenSpace().ToString());
         EXPECT_EQ(gfx::Rect(gfx::Point(), trackingSize).ToString(), occlusion.occlusionInTargetSurface().ToString());
     }
 };
 
 ALL_OCCLUSIONTRACKER_TEST(OcclusionTrackerTestMinimumTrackingSize);
 
 }  // namespace
 }  // namespace cc