Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1145793002: Add missing break statement in chromeos path switch (Closed)

Created:
5 years, 7 months ago by robert.bradford
Modified:
5 years, 7 months ago
Reviewers:
*oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing break statement in chromeos path switch Following https://codereview.chromium.org/1129863003/ which added support for loading an apply an ICC file based on EDID product id a new entry was added to the chromeos paths switch statement. Unfortunately the break statement was missing in the newly added case. Failing to break from the switch statement triggered a DCHECK failure in path_service.cc which would result in in asserts in builds where DCHECK is fatal. BUG=489643 TEST=None Committed: https://crrev.com/5849cfec2bbfc5e16a3c033c15e73d09a1b6af4f Cr-Commit-Position: refs/heads/master@{#330549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chromeos/chromeos_paths.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
robert.bradford
Hi oshima@ please take a look at this change when you can.
5 years, 7 months ago (2015-05-19 11:13:37 UTC) #3
oshima
lgtm
5 years, 7 months ago (2015-05-19 16:47:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145793002/1
5 years, 7 months ago (2015-05-19 16:52:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 17:29:03 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:29:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5849cfec2bbfc5e16a3c033c15e73d09a1b6af4f
Cr-Commit-Position: refs/heads/master@{#330549}

Powered by Google App Engine
This is Rietveld 408576698