LayoutTests/fast/multicol/explicit-columns-auto.html - Issue 1145773002: Setting -webkit-column-count to auto is the same as not setting it.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/explicit-columns-auto.html

Issue 1145773002: Setting -webkit-column-count to auto is the same as not setting it. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <style>

	4 .explicitlyNoColumns { -webkit-columns:auto; }
	rune 2015/05/19 09:18:15 Inconsistent indentation. 2 spaces here and 4 spac Inconsistent indentation. 2 spaces here and 4 spaces in the script below. mstensho (USE GERRIT) 2015/05/19 09:37:17 Done. Show quoted text On 2015/05/19 09:18:15, rune wrote: > Inconsistent indentation. 2 spaces here and 4 spaces in the script below. Done.
	5 </style>

	6

	7 <div id="elm"></div>

	8

	9 <script>

	10 description("Test that setting columns to auto is the same as not setting it at all.");

	11 onload = function() {

	12 document.body.offsetTop;
	rune 2015/05/19 09:18:15 The offsetTop forced style/layout should suffice. The offsetTop forced style/layout should suffice. No need to put it in an onload-handler? mstensho (USE GERRIT) 2015/05/19 09:37:17 Done. Show quoted text On 2015/05/19 09:18:15, rune wrote: > The offsetTop forced style/layout should suffice. No need to put it in an > onload-handler? Done.
	13 document.getElementById('elm').className = "explicitlyNoColumns";

	14 if (window.internals) {

	15 // Need to call updateStyleAndReturnAffectedElementCount() first, to get style recalculated,

	16 // so that the necessary objects get marked for layout (which, if th e test passes, should be 0).

	17 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "1" );

	18 shouldBe("internals.needsLayoutCount()", "0");

	19 } else {

	20 testFailed("There's no web exposed API usable for this test. The bug doesn't affect layout in a reliable way. Please rerun inside the layout test fr amework.");

	21 }

	22 }

	23 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/explicit-columns-auto-expected.txt » ('j') | no next file with comments »