Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: src/objects.cc

Issue 1145693002: Remove undefined-check from GetElementWithReceiver (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 703ba4aeb0d4fb0fe41c32511ad37010b9960a82..e89e2c8d3711fa9addb4bd0dca521d1615b407ac 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -660,11 +660,7 @@ MaybeHandle<Object> Object::GetElementWithReceiver(Isolate* isolate,
Handle<Object> object,
Handle<Object> receiver,
uint32_t index) {
- if (object->IsUndefined()) {
- // TODO(verwaest): Why is this check here?
- UNREACHABLE();
- return isolate->factory()->undefined_value();
- }
+ DCHECK(!object->IsUndefined());
// Iterate up the prototype chain until an element is found or the null
// prototype is encountered.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698