Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1145693002: Remove undefined-check from GetElementWithReceiver (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove undefined-check from GetElementWithReceiver BUG= Committed: https://crrev.com/6c98bb1e6d7074052144dff201e8105130b31526 Cr-Commit-Position: refs/heads/master@{#28443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/objects.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 7 months ago (2015-05-18 12:26:36 UTC) #2
Igor Sheludko
lgtm
5 years, 7 months ago (2015-05-18 12:45:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145693002/1
5 years, 7 months ago (2015-05-18 12:52:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 13:15:15 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 13:15:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c98bb1e6d7074052144dff201e8105130b31526
Cr-Commit-Position: refs/heads/master@{#28443}

Powered by Google App Engine
This is Rietveld 408576698