Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 1145653004: ARM64: Propagate notification about aborted compilation from RegExpEngine to MacroAssembler. (Closed)

Created:
5 years, 7 months ago by Igor Sheludko
Modified:
5 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM64: Propagate notification about aborted compilation from RegExpEngine to MacroAssembler. BUG=chromium:489290 LOG=Y Committed: https://crrev.com/8bc3dc0372283eaaadc20efeaf9909c3e493b2f7 Cr-Commit-Position: refs/heads/master@{#28455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/arm64/regexp-macro-assembler-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/regexp-macro-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/regexp-macro-assembler-tracer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp-macro-assembler-tracer.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 7 months ago (2015-05-18 16:18:02 UTC) #2
Michael Starzinger
LGTM.
5 years, 7 months ago (2015-05-18 17:12:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145653004/1
5 years, 7 months ago (2015-05-18 17:14:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 19:41:34 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:12:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bc3dc0372283eaaadc20efeaf9909c3e493b2f7
Cr-Commit-Position: refs/heads/master@{#28455}

Powered by Google App Engine
This is Rietveld 408576698