Get rid of DEFINE_TESTCLASS() macro.

src/core/SkTileGrid.h

Index: src/core/SkTileGrid.h
diff --git a/src/core/SkTileGrid.h b/src/core/SkTileGrid.h
index 77d972850fe7bb70fb14ca657bb92c3842e72968..d7e4166a05a338204db595cd2f91addb838efbc9 100644
--- a/src/core/SkTileGrid.h
+++ b/src/core/SkTileGrid.h
@@ -69,9 +69,10 @@ public:
     enum {
         kTileFinished = -1,
     };
-private:
+
     SkTDArray<void*>& tile(int x, int y);

[mtklein, 2013/12/13 15:24:31]

I'm not keen on having to expose this guy.  Seems super abstraction-breaking.

Some alternatives:

1)  Make this method protected, subclass it inside the test code and make it
public there.
  [SkTileGrid.h]
  protected:
        SkTDArray<void*>& tile(int x, int y);  // For testing only.
 
  [TileGridTest.cpp]
  class SkTileGridForTesting : public SkTileGrid {
  public:
      SkTDArray<void*>& tile(int x, int y) { return SkTileGrid::tile(x,y); }
  };
  (then use SkTileGridForTesting instead of SkTileGrid in tests)

2)  Keep the method public, but lock it down to only what we really need for the
tests:
  public:
      int tileCount(int x, int y) const;  // For testing only.

Leaning towards 2) myself.

[tfarina, 2013/12/13 21:00:08]

Done.

 
+private:
     int fXTileCount, fYTileCount, fTileCount;
     SkTileGridPicture::TileGridInfo fInfo;
     SkTDArray<void*>* fTileData;
@@ -79,7 +80,6 @@ private:
     SkIRect fGridBounds;
     SkTileGridNextDatumFunctionPtr fNextDatumFunction;
 
-    friend class TileGridTest;
     typedef SkBBoxHierarchy INHERITED;
 };