Get rid of DEFINE_TESTCLASS() macro.

Get rid of DEFINE_TESTCLASS() macro.

Remaining tests were rewrite to use DEF_TEST() macro instead. This fixes
the FIXME in TestClassDef.h

BUG=None
TEST=tests
R=mtklein@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12760

[tfarina, 2013-12-12 22:03:51]

No functional changes to TileGridTest.cpp and ImageFilterTest.cpp, just
indentation fixes.

[mtklein, 2013-12-13 15:24:31]

this is exciting.  it's always nice to have TODOs done!

https://codereview.chromium.org/114563003/diff/1/src/core/SkTileGrid.h
File src/core/SkTileGrid.h (left):

https://codereview.chromium.org/114563003/diff/1/src/core/SkTileGrid.h#oldcode73
src/core/SkTileGrid.h:73: SkTDArray<void*>& tile(int x, int y);
I'm not keen on having to expose this guy.  Seems super abstraction-breaking.

Some alternatives:

1)  Make this method protected, subclass it inside the test code and make it
public there.
  [SkTileGrid.h]
  protected:
        SkTDArray<void*>& tile(int x, int y);  // For testing only.
 
  [TileGridTest.cpp]
  class SkTileGridForTesting : public SkTileGrid {
  public:
      SkTDArray<void*>& tile(int x, int y) { return SkTileGrid::tile(x,y); }
  };
  (then use SkTileGridForTesting instead of SkTileGrid in tests)

2)  Keep the method public, but lock it down to only what we really need for the
tests:
  public:
      int tileCount(int x, int y) const;  // For testing only.

Leaning towards 2) myself.

https://codereview.chromium.org/114563003/diff/1/tests/TestClassDef.h
File tests/TestClassDef.h (right):

https://codereview.chromium.org/114563003/diff/1/tests/TestClassDef.h#newcode21
tests/TestClassDef.h:21: #define DEFINE_TESTCLASS_SHORT(function)               
                                 \
Does anything still use DEFINE_TESTCLASS_SHORT now?  If not, let's take the
FIXME one step further and fold it into DEF_TEST.

https://codereview.chromium.org/114563003/diff/1/tests/TileGridTest.cpp
File tests/TileGridTest.cpp (right):

https://codereview.chromium.org/114563003/diff/1/tests/TileGridTest.cpp#newco...
tests/TileGridTest.cpp:56: DEF_TEST(UnalignedQuery, reporter) {
Can you name these tests TileGrid_UnalignedQuery and
TileGrid_OverlapOffsetQueryAlignment?

[tfarina, 2013-12-13 21:00:07]

https://codereview.chromium.org/114563003/diff/1/src/core/SkTileGrid.h
File src/core/SkTileGrid.h (left):

https://codereview.chromium.org/114563003/diff/1/src/core/SkTileGrid.h#oldcode73
src/core/SkTileGrid.h:73: SkTDArray<void*>& tile(int x, int y);
On 2013/12/13 15:24:31, mtklein wrote:
> I'm not keen on having to expose this guy.  Seems super abstraction-breaking.
> 
> Some alternatives:
> 
> 1)  Make this method protected, subclass it inside the test code and make it
> public there.
>   [SkTileGrid.h]
>   protected:
>         SkTDArray<void*>& tile(int x, int y);  // For testing only.
>  
>   [TileGridTest.cpp]
>   class SkTileGridForTesting : public SkTileGrid {
>   public:
>       SkTDArray<void*>& tile(int x, int y) { return SkTileGrid::tile(x,y); }
>   };
>   (then use SkTileGridForTesting instead of SkTileGrid in tests)
> 
> 2)  Keep the method public, but lock it down to only what we really need for
the
> tests:
>   public:
>       int tileCount(int x, int y) const;  // For testing only.
> 
> Leaning towards 2) myself.

Done.

https://codereview.chromium.org/114563003/diff/1/tests/TestClassDef.h
File tests/TestClassDef.h (right):

https://codereview.chromium.org/114563003/diff/1/tests/TestClassDef.h#newcode21
tests/TestClassDef.h:21: #define DEFINE_TESTCLASS_SHORT(function)               
                                 \
On 2013/12/13 15:24:31, mtklein wrote:
> Does anything still use DEFINE_TESTCLASS_SHORT now?  If not, let's take the
> FIXME one step further and fold it into DEF_TEST.
It is still used, mainly by the PathOps* tests. I will address them in the next
patch.

https://codereview.chromium.org/114563003/diff/1/tests/TileGridTest.cpp
File tests/TileGridTest.cpp (right):

https://codereview.chromium.org/114563003/diff/1/tests/TileGridTest.cpp#newco...
tests/TileGridTest.cpp:56: DEF_TEST(UnalignedQuery, reporter) {
On 2013/12/13 15:24:31, mtklein wrote:
> Can you name these tests TileGrid_UnalignedQuery and
> TileGrid_OverlapOffsetQueryAlignment?

Done.

[mtklein, 2013-12-17 18:06:06]

On 2013/12/13 21:00:07, tfarina wrote:
> https://codereview.chromium.org/114563003/diff/1/src/core/SkTileGrid.h
> File src/core/SkTileGrid.h (left):
> 
>
https://codereview.chromium.org/114563003/diff/1/src/core/SkTileGrid.h#oldcode73
> src/core/SkTileGrid.h:73: SkTDArray<void*>& tile(int x, int y);
> On 2013/12/13 15:24:31, mtklein wrote:
> > I'm not keen on having to expose this guy.  Seems super
abstraction-breaking.
> > 
> > Some alternatives:
> > 
> > 1)  Make this method protected, subclass it inside the test code and make it
> > public there.
> >   [SkTileGrid.h]
> >   protected:
> >         SkTDArray<void*>& tile(int x, int y);  // For testing only.
> >  
> >   [TileGridTest.cpp]
> >   class SkTileGridForTesting : public SkTileGrid {
> >   public:
> >       SkTDArray<void*>& tile(int x, int y) { return SkTileGrid::tile(x,y); }
> >   };
> >   (then use SkTileGridForTesting instead of SkTileGrid in tests)
> > 
> > 2)  Keep the method public, but lock it down to only what we really need for
> the
> > tests:
> >   public:
> >       int tileCount(int x, int y) const;  // For testing only.
> > 
> > Leaning towards 2) myself.
> 
> Done.
> 
> https://codereview.chromium.org/114563003/diff/1/tests/TestClassDef.h
> File tests/TestClassDef.h (right):
> 
>
https://codereview.chromium.org/114563003/diff/1/tests/TestClassDef.h#newcode21
> tests/TestClassDef.h:21: #define DEFINE_TESTCLASS_SHORT(function)             
 
>                                  \
> On 2013/12/13 15:24:31, mtklein wrote:
> > Does anything still use DEFINE_TESTCLASS_SHORT now?  If not, let's take the
> > FIXME one step further and fold it into DEF_TEST.
> It is still used, mainly by the PathOps* tests. I will address them in the
next
> patch.
> 
> https://codereview.chromium.org/114563003/diff/1/tests/TileGridTest.cpp
> File tests/TileGridTest.cpp (right):
> 
>
https://codereview.chromium.org/114563003/diff/1/tests/TileGridTest.cpp#newco...
> tests/TileGridTest.cpp:56: DEF_TEST(UnalignedQuery, reporter) {
> On 2013/12/13 15:24:31, mtklein wrote:
> > Can you name these tests TileGrid_UnalignedQuery and
> > TileGrid_OverlapOffsetQueryAlignment?
> 
> Done.

lgtm

[tfarina, 2013-12-18 22:15:25]

Committed patchset #3 manually as r12760 (presubmit successful).