sky/sdk/lib/framework/fn.dart - Issue 1145623003: [Effen] Now that we have RenderNode.parent again, we can have mid-tree sync() work properly again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/fn.dart

Issue 1145623003: [Effen] Now that we have RenderNode.parent again, we can have mid-tree sync() work properly again. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/sdk/lib/framework/fn.dart

diff --git a/sky/sdk/lib/framework/fn.dart b/sky/sdk/lib/framework/fn.dart

index f181102004c13045ed7fdef4ec78fc3ef3a26d16..9f51a17da881bb1d1bc64ca004f17b18cafe46d3 100644

--- a/sky/sdk/lib/framework/fn.dart

+++ b/sky/sdk/lib/framework/fn.dart

@@ -886,7 +886,7 @@ abstract class Component extends UINode {

return;

_trace('$_key rebuilding...');

- _sync(null, null, null); // TODO(ianh): figure out how passing "null, null, null" here is ok

+ _sync(null, _root.parent, _root.parent.childAfter(_root));

}

void scheduleBuild() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »