Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1145593002: Revert of Non-SFI mode: Build nacl_helper_nonsfi_unittests (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 7 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, hamaji, mazda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Non-SFI mode: Build nacl_helper_nonsfi_unittests (patchset #4 id:80001 of https://codereview.chromium.org/1137553003/) Reason for revert: This breaks the asan build. See comments on the original CL. Original issue's description: > Non-SFI mode: Build nacl_helper_nonsfi_unittests > > This CL starts to build nacl_helper_nonsfi_unittests. > The binary is not yet enabled to run on bots. It will be done in a following CL. > > TEST=Ran locally. Ran build bots. Ran build bots with editing configuration to include nacl_helper_nonsfi_unittests. > BUG=358465 > > Committed: https://crrev.com/72c418b09bbf90505f54df2b76285650acd97960 > Cr-Commit-Position: refs/heads/master@{#330069} TBR=mseaborn@chromium.org,mdempsky@chromium.org,thakis@chromium.org,jln@chromium.org,hidehiko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=358465 Committed: https://crrev.com/aad01297ee28c48a3021339568cacaf16f37fdc0 Cr-Commit-Position: refs/heads/master@{#330147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -302 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc View 7 chunks +13 lines, -105 lines 0 comments Download
D components/nacl_helper_nonsfi_unittests.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
M components/nacl_nonsfi.gyp View 5 chunks +3 lines, -127 lines 0 comments Download
M sandbox/linux/system_headers/arm_linux_syscalls.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sandbox/linux/tests/unit_tests.cc View 6 chunks +0 lines, -16 lines 0 comments Download
M sandbox/sandbox_nacl_nonsfi.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
M testing/gtest_nacl.gyp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hans
Created Revert of Non-SFI mode: Build nacl_helper_nonsfi_unittests
5 years, 7 months ago (2015-05-15 18:43:05 UTC) #1
mdempsky
lgtm
5 years, 7 months ago (2015-05-15 18:44:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145593002/1
5 years, 7 months ago (2015-05-15 18:44:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 18:47:44 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 18:48:31 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aad01297ee28c48a3021339568cacaf16f37fdc0
Cr-Commit-Position: refs/heads/master@{#330147}

Powered by Google App Engine
This is Rietveld 408576698