Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1145583003: media: Implement MediaDrmBridge::SetServerCertificate(). (Closed)

Created:
5 years, 7 months ago by xhwang
Modified:
5 years, 7 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@m_sdk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Implement MediaDrmBridge::SetServerCertificate(). Also update MediaDrmBridge to use org.chromium.base.Log. See bug 472152. BUG=487435, 472152 TEST=Tested using a test certificate. We only get one key request instead of two, and playback works. Committed: https://crrev.com/4e0f76e75923b3aaed2ef071681cb041de17093e Cr-Commit-Position: refs/heads/master@{#330665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaDrmBridge.java View 3 chunks +22 lines, -1 line 0 comments Download
M media/base/android/media_drm_bridge.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xhwang
Still needs to find a way to test it. Otherwise, PTAL
5 years, 7 months ago (2015-05-15 18:31:22 UTC) #2
ddorwin
lgtm
5 years, 7 months ago (2015-05-18 16:32:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145583003/1
5 years, 7 months ago (2015-05-20 00:22:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 01:15:55 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 01:17:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e0f76e75923b3aaed2ef071681cb041de17093e
Cr-Commit-Position: refs/heads/master@{#330665}

Powered by Google App Engine
This is Rietveld 408576698